Feat: Support api_type for Jira receiver in Alertmanager config secret#8218
Merged
simonpasquier merged 7 commits intoprometheus-operator:mainfrom Jan 6, 2026
Conversation
7411542 to
ba96cf2
Compare
to cover more test case
to fix mandatory field issue
to match the test case
Contributor
Author
|
Hi @simonpasquier and @heliapb, I separated this from #7971 for merging only the new field for Alertmanager config secret first as it should be easier for review. Please have a look and suggest. |
5 tasks
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
Thanks for the PR! Shouldn't we also check the value of the field which should be one of auto, cloud or datacenter?
to prevent unexpected value in api_type
Contributor
Author
|
@simonpasquier Updated |
to fix the validation issue
to cover wrong api type detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is separated for adding only api_type in Jira receiver under Alertmanager config secret for easier to review.
Relate #7971
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Unit Testing
Changelog entry