feat: use minReadySeconds as default first delay#8201
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Jan 5, 2026
Merged
Conversation
85fd9b7 to
205bbbb
Compare
205bbbb to
7352ed1
Compare
This commit removes the `dispatchStartDelay` field from the Alertmanager CRD and uses instead the `minReadySeconds` value as the default duration to delay the first flush of aggregation groups. When Kubernetes performs pod updates (due to spec updates or pod eviction),`minReadySeconds` defines how long a statefulset's pod should be ready before kube-controller-manager can proceed with the next pod update. The main use case of `minReadySeconds` is to ensure that Prometheus has resent all alerts before updating the next pod hence it makes sense for Alertmanager to wait the same amount of time before sending alert notifications. Users who want to use another value for `--dispatch.start-delay` can customize it using the `.spec.additionalArgs` field. The removal of `dispatchStartDelay` is possible because the field hasn't been made available in any public release. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
7352ed1 to
9db1527
Compare
slashpai
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the
dispatchStartDelayfield from the Alertmanager CRD and uses instead theminReadySecondsvalue as the default duration to delay the first flush of aggregation groups.When Kubernetes performs pod updates (due to spec updates or pod eviction),
minReadySecondsdefines how long a statefulset's pod should be ready before kube-controller-manager can proceed with the next pod update. The main use case ofminReadySecondsis to ensure that Prometheus has resent all alerts before updating the next pod hence it makes sense for Alertmanager to wait the same amount of time before sending alert notifications. Users who want to use another value for--dispatch.start-delaycan customize it using the.spec.additionalArgsfield.The removal of
dispatchStartDelayis possible because the field hasn't been made available in any public release.Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.