Skip to content

feat: add incident.io support to am config secret#8190

Merged
simonpasquier merged 2 commits intoprometheus-operator:mainfrom
heliapb:feat/add_incidentio_config
Dec 19, 2025
Merged

feat: add incident.io support to am config secret#8190
simonpasquier merged 2 commits intoprometheus-operator:mainfrom
heliapb:feat/add_incidentio_config

Conversation

@heliapb
Copy link
Member

@heliapb heliapb commented Dec 17, 2025

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Closes: #ISSUE-NUMBER

If you're contributing for the first-time, check our contribution guidelines.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
@heliapb heliapb force-pushed the feat/add_incidentio_config branch from 308e07f to 462cea5 Compare December 18, 2025 15:05
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier simonpasquier merged commit 99deb06 into prometheus-operator:main Dec 19, 2025
34 of 38 checks passed
@heliapb heliapb deleted the feat/add_incidentio_config branch December 19, 2025 12:15
Comment on lines +122 to +123
MattermostConfigs []*mattermostConfig `yaml:"mattermost_configs,omitempty"`
IncidentioConfigs []*incidentioConfig `yaml:"incidentio_config,omitempty"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @simonpasquier noticed when rebasing #8014 that was defined as incidentio_config instead of incidentio_configs. Fixed on the 8014 pr but just to note.

@heliapb heliapb mentioned this pull request Jan 7, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants