Skip to content

Feat: Add the new dispatch.start-delay flag for Alertmanager#8177

Merged
simonpasquier merged 9 commits intoprometheus-operator:mainfrom
nutmos:feat/add-support-dispatch.start-delay-flag
Dec 17, 2025
Merged

Feat: Add the new dispatch.start-delay flag for Alertmanager#8177
simonpasquier merged 9 commits intoprometheus-operator:mainfrom
nutmos:feat/add-support-dispatch.start-delay-flag

Conversation

@nutmos
Copy link
Contributor

@nutmos nutmos commented Dec 14, 2025

Description

Add the new --dispatch.start-delay flag for Alertmanager

Closes: #8165

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Unit Testing

Changelog entry

 - Add the new --dispatch.start-delay flag for Alertmanager

@nutmos nutmos requested a review from a team as a code owner December 14, 2025 13:08
@nutmos
Copy link
Contributor Author

nutmos commented Dec 15, 2025

We can keep this until 0.30.0 is released.


// AlertmanagerDispatchSpec defines the dispatch command line flags when starting Alertmanager.
// +k8s:openapi-gen=true
type AlertmanagerDispatchSpec struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nutmos I don't think you need to create a separated type for this, could just be directly under the am spec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heliapb Updated

@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 17, 2025
// limits defines the limits command line flags when starting Alertmanager.
// +optional
Limits *AlertmanagerLimitsSpec `json:"limits,omitempty"`
// dispatch defines the web command line flags when starting Alertmanager.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to mention the min Alertmanager version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonpasquier Updated

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits

nutmos and others added 2 commits December 17, 2025 21:23
Update description as suggested.

Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier enabled auto-merge (squash) December 17, 2025 13:58
@simonpasquier simonpasquier merged commit 65da264 into prometheus-operator:main Dec 17, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for Alertmanager dispatch.start-delay

3 participants