Feat: Add CR for Mattermost Receiver in Alertmanager#8176
Open
nutmos wants to merge 83 commits intoprometheus-operator:mainfrom
Open
Feat: Add CR for Mattermost Receiver in Alertmanager#8176nutmos wants to merge 83 commits intoprometheus-operator:mainfrom
nutmos wants to merge 83 commits intoprometheus-operator:mainfrom
Conversation
to cover the case of requestedAck
to test error
to reflect new changes
to test scenario
to add it later
to add it later after merge
Contributor
Author
|
@simonpasquier Could you please review? |
| ) | ||
|
|
||
| // MattermostPriorityConfig configures the parameters related to the priority of the message. | ||
| // +kubebuilder:validation:XValidation:rule="!((self.priority != 'Important' && self.priority != 'Urgent') && self.requestedAck == true)",message="requestedAck can only be set to true when priority is Urgent or Important" |
Contributor
There was a problem hiding this comment.
same remark here, while the validation would have been nice, the value can be a Go template string.
Contributor
Author
There was a problem hiding this comment.
@simonpasquier Sorry I don't really get that. Could you please elaborate more or explain what is the expected validation?
Contributor
Author
There was a problem hiding this comment.
@simonpasquier Hi, I'm happy to fix this. Could you mention exactly what is the expected way to implement?
…ired per suggestion
to fix merge conflict and reflect new changes
to match the new method ValidateURLPtr
fix the wrong golden file name
to prevent linter to check bool values
to resolve merge conflict
to fix merge conflict
Contributor
Author
|
@simonpasquier Any chance to review this pls? |
to support template
to cover priority testing
using lowercase
to reflect new changes
to resolve merge conflicts
Contributor
Author
|
@simonpasquier @heliapb Could you please give any suggestion? |
Contributor
Author
|
@heliapb @simonpasquier Hi, any suggestions here? |
to ensure the value of template url will not have any issue
to simplify after changing the variable type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alertmanager 0.30.0 supports Mattermost receiver. This PR adds the CR for the integration to this feature in Alertmanager.
Closes: #8164
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Unit Testing
Changelog entry