Feat: add maximum version to EC2 and Lightsail SD#8175
Merged
simonpasquier merged 9 commits intoprometheus-operator:mainfrom Dec 18, 2025
Merged
Conversation
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
we should rather reject the ScrapeConfigs in pkg/prometheus/resource_selector.go
Contributor
Author
|
@simonpasquier Updated, please review |
simonpasquier
approved these changes
Dec 18, 2025
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
Thanks!
Is there any way that we can convert EC2/Lightsail SD configs to the new AWS SD config?
Contributor
Author
|
@simonpasquier Let me try to explore it. Almost all configs are the same. I'll open a new PR to try it out. |
1 task
|
fyi i have raised an issue about this in #8305 because i think this version gating might be premature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since version 3.8.0, EC2 and Lightsail SDs are combined into AWS SD.
This PR adds logic to remove EC2 and Lightsail SDs when running on Prometheus >= 3.8.0.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
E2E Test Cases
Changelog entry