Skip to content

feat: add timeout to alertmanager slack config#8161

Merged
simonpasquier merged 2 commits intoprometheus-operator:mainfrom
heliapb:feat/add_timeout_slack
Dec 17, 2025
Merged

feat: add timeout to alertmanager slack config#8161
simonpasquier merged 2 commits intoprometheus-operator:mainfrom
heliapb:feat/add_timeout_slack

Conversation

@heliapb
Copy link
Member

@heliapb heliapb commented Dec 10, 2025

Description

From new alertmanager version, add timeout to slack config

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


@heliapb heliapb requested a review from a team as a code owner December 10, 2025 22:45
@heliapb heliapb marked this pull request as draft December 10, 2025 23:01
@heliapb heliapb force-pushed the feat/add_timeout_slack branch from fa2bf4d to 30c96d8 Compare December 11, 2025 09:17
@heliapb heliapb marked this pull request as ready for review December 11, 2025 09:31
simonpasquier
simonpasquier previously approved these changes Dec 16, 2025
@simonpasquier
Copy link
Contributor

ah sorry another merge conflict to resolve.

Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
auto-merge was automatically disabled December 17, 2025 13:22

Head branch was pushed to by a user without write access

@heliapb heliapb force-pushed the feat/add_timeout_slack branch from 5227b0e to 8cd20bc Compare December 17, 2025 13:22
@heliapb
Copy link
Member Author

heliapb commented Dec 17, 2025

ah sorry another merge conflict to resolve.

Don't worry, merge conflicts is a part of the fun 😄 I guess I can add the convertTimeout check as in #8014 (comment) in the #8014 pr.

@simonpasquier simonpasquier enabled auto-merge (squash) December 17, 2025 13:53
@simonpasquier simonpasquier merged commit f3b2dae into prometheus-operator:main Dec 17, 2025
22 checks passed
@heliapb heliapb deleted the feat/add_timeout_slack branch December 17, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants