Skip to content

chore: add standardization of import as aliases#8114

Closed
dongjiang1989 wants to merge 7 commits intoprometheus-operator:mainfrom
kubeservice-stack:add-importas
Closed

chore: add standardization of import as aliases#8114
dongjiang1989 wants to merge 7 commits intoprometheus-operator:mainfrom
kubeservice-stack:add-importas

Conversation

@dongjiang1989
Copy link
Member

@dongjiang1989 dongjiang1989 commented Nov 23, 2025

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

If it fixes an existing issue (bug or feature), use the following keyword:

Closes: #ISSUE-NUMBER

standardization of import as aliases

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

NONE

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 requested a review from a team as a code owner November 23, 2025 15:48
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
heliapb
heliapb previously approved these changes Nov 24, 2025
@dongjiang1989
Copy link
Member Author

cc @simonpasquier PTAL

@simonpasquier
Copy link
Contributor

LGTM but can you rebase?

@dongjiang1989
Copy link
Member Author

LGTM but can you rebase?

@simonpasquier follow this #8430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants