Skip to content

enable NoMaps Linter#8098

Merged
simonpasquier merged 3 commits intoprometheus-operator:mainfrom
kartikangiras:nomapslinter
Dec 24, 2025
Merged

enable NoMaps Linter#8098
simonpasquier merged 3 commits intoprometheus-operator:mainfrom
kartikangiras:nomapslinter

Conversation

@kartikangiras
Copy link
Contributor

@kartikangiras kartikangiras commented Nov 16, 2025 •
edited by simonpasquier
Loading

Description

NoMaps KAL Linter enabled for API types

Realted to #7870

Closes #8135

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

@kartikangiras kartikangiras requested a review from a team as a code owner November 16, 2025 18:41
@kartikangiras kartikangiras changed the title feat: enable Nomapslinter feat: enable NoMaps Linter Nov 16, 2025
@kartikangiras
Copy link
Contributor Author

kartikangiras commented Nov 17, 2025

@simonpasquier PTAL

simonpasquier
simonpasquier reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We can't change the structure of the APIs because it would break users. Instead I recommend to configure exceptions for all existing maps.

@kartikangiras kartikangiras changed the title feat: enable NoMaps Linter enable NoMaps Linter Nov 23, 2025
@kartikangiras
Copy link
Contributor Author

kartikangiras commented Nov 23, 2025 •
edited
Loading

Thanks for the PR! We can't change the structure of the APIs because it would break users. Instead I recommend to configure exceptions for all existing maps.

@simonpasquier i configured the nomaps lint exception for all the existing maps keeping the APIs structure preserved.

simonpasquier
simonpasquier reviewed Dec 5, 2025
View reviewed changes
@pull-request-size pull-request-size bot added size/S and removed size/M labels Dec 5, 2025
@kartikangiras
Copy link
Contributor Author

kartikangiras commented Dec 5, 2025

@simonpasquier i have fixed the crd validations differences , nomaps kal linter is now configured for all the existing maps exceptionally without any user breakage

simonpasquier
simonpasquier previously approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

simonpasquier
simonpasquier reviewed Dec 9, 2025
View reviewed changes
heliapb
heliapb reviewed Dec 16, 2025
View reviewed changes
Copy link
Member

@heliapb heliapb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kartikangiras could you pls check there seems to merge conflicts, could you rebase so to tackle those. Thanks

@kartikangiras
Copy link
Contributor Author

kartikangiras commented Dec 16, 2025

Hi @kartikangiras could you pls check there seems to merge conflicts, could you rebase so to tackle those. Thanks

@heliapb resolved.

simonpasquier
simonpasquier previously approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier
Copy link
Contributor

simonpasquier commented Dec 22, 2025

ah can you rebase?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 22, 2025
@pull-request-size pull-request-size bot added size/S and removed size/M labels Dec 22, 2025
@kartikangiras
Copy link
Contributor Author

kartikangiras commented Dec 22, 2025

@simonpasquier done rebased.

simonpasquier
simonpasquier reviewed Dec 24, 2025
View reviewed changes
simonpasquier
simonpasquier approved these changes Dec 24, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier enabled auto-merge (squash) December 24, 2025 10:26
@simonpasquier simonpasquier merged commit 6893cff into prometheus-operator:main Dec 24, 2025
22 checks passed
@kartikangiras kartikangiras deleted the nomapslinter branch January 5, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonpasquier simonpasquier simonpasquier approved these changes

@heliapb heliapb heliapb approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nomaps

3 participants

@kartikangiras @simonpasquier @heliapb