feat: avoid statefulset's rollout due to new rule configmaps#8010
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Oct 16, 2025
Merged
feat: avoid statefulset's rollout due to new rule configmaps#8010simonpasquier merged 1 commit intoprometheus-operator:mainfrom
simonpasquier merged 1 commit intoprometheus-operator:mainfrom
Conversation
4c4823a to
90d8fb7
Compare
90d8fb7 to
f2cdcd5
Compare
This commit avoids the situation where the operator would update the StatefulSet because the concatenation of configured rules exceeds the maximum ConfigMap size. To alleviate the issue, the operator now configures the StatefulSet to always mount 3 "rule" ConfigMaps with "optional: true". When the operator generates an additional ConfigMap, it will get mounted automatically into the pod and the config-reloader sidecar will detect and apply the new configuration. When the number of "concrete" ConfigMaps decreases, the operation is also non-disruptive. The number has been chosen arbitrarily and it could change in the future but 3 seems a good choice (original reports were complaining about the number of ConfigMaps fluctuating between 1 and 2). The change applies both to Prometheus and ThanosRuler. Closes prometheus-operator#5085 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
f2cdcd5 to
8055376
Compare
slashpai
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit avoids the situation where the operator would update the StatefulSet because the concatenation of configured rules exceeds the maximum ConfigMap size. To alleviate the issue, the operator now configures the StatefulSet to always mount 3 "rule" ConfigMaps with "optional: true". When the operator generates an additional ConfigMap, it will get mounted automatically into the pod and the config-reloader sidecar will detect and apply the new configuration. When the number of "concrete" ConfigMaps decreases, the operation is also non-disruptive.
The number has been chosen arbitrarily and it could change in the future but 3 seems a good choice (original reports were complaining about the number of ConfigMaps fluctuating between 1 and 2).
The change applies both to Prometheus and ThanosRuler.
Closes #5085
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.