change: remove feature flag metadata-wal-records when prometheus version higher the 3.4#7893
Merged
simonpasquier merged 6 commits intoprometheus-operator:mainfrom Sep 11, 2025
Conversation
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
LGTM! Can we add a comment explaining that the metadata-wal-records feature flag isn't mandatory starting with Prometheus v3.4.0?
Member
Author
added a small comment with link to the issue. pls review. |
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
simonpasquier
approved these changes
Sep 11, 2025
8e6f399
into
prometheus-operator:main
35 of 37 checks passed
metadata-wal-records when prometheus version higher the 3.4metadata-wal-records when prometheus version higher the 3.4
metadata-wal-records when prometheus version higher the 3.4metadata-wal-records when prometheus version higher the 3.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From issue #7889
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.