Use map list type for status bindings#7829
Merged
simonpasquier merged 3 commits intoprometheus-operator:mainfrom Aug 21, 2025
Merged
Use map list type for status bindings#7829simonpasquier merged 3 commits intoprometheus-operator:mainfrom
simonpasquier merged 3 commits intoprometheus-operator:mainfrom
Conversation
Contributor
Author
|
@simonpasquier PTAL! |
simonpasquier
previously approved these changes
Aug 21, 2025
pkg/prometheus/operator.go
Outdated
| found = true | ||
| break | ||
|
|
||
| applyCfg := ApplyConfigurationFromServiceMonitor(smon, func(binding monitoringv1.WorkloadBinding) bool { |
Contributor
There was a problem hiding this comment.
In the current form, we don't even need to check for the presence of the binding in the list. The API should do the right thing: insert the item if the key (resource+name+namespace) isn't present otherwise update.
Contributor
Author
|
@simonpasquier PTAL |
simonpasquier
approved these changes
Aug 21, 2025
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
Let's tackle the next optimization in #7827
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use map list type for status bindings
Closes: #7790
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.