feat: add workqueue metrics#7776
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Aug 6, 2025
Merged
Conversation
This commit adds the following metrics on controller's workqueues: * prometheus_operator_workqueue_depth * prometheus_operator_workqueue_adds_total * prometheus_operator_workqueue_latency_seconds_bucket * prometheus_operator_workqueue_latency_seconds_count * prometheus_operator_workqueue_latency_seconds_sum * prometheus_operator_workqueue_work_duration_seconds_bucket * prometheus_operator_workqueue_work_duration_seconds_count * prometheus_operator_workqueue_work_duration_seconds_sum * prometheus_operator_workqueue_unfinished_work_seconds * prometheus_operator_workqueue_longest_running_processor_seconds * prometheus_operator_workqueue_retries_total Signed-off-by: Simon Pasquier <spasquie@redhat.com>
slashpai
reviewed
Aug 6, 2025
| Name: "prometheus_operator_workqueue_depth", | ||
| Help: "Depth of the queue", | ||
| }, | ||
| []string{"name"}, |
Contributor
There was a problem hiding this comment.
could we include controller_type also?
Contributor
Author
There was a problem hiding this comment.
it's already included because the registerer injects the controller label.
# HELP prometheus_operator_workqueue_unfinished_work_seconds How many seconds has been spent by processing work which is not yet finished. A growing number indicates a stuck thread.
# TYPE prometheus_operator_workqueue_unfinished_work_seconds gauge
prometheus_operator_workqueue_unfinished_work_seconds{controller="alertmanager",name="alertmanager"} 0
prometheus_operator_workqueue_unfinished_work_seconds{controller="alertmanager",name="alertmanager_status"} 0
prometheus_operator_workqueue_unfinished_work_seconds{controller="prometheus",name="prometheus"} 0
prometheus_operator_workqueue_unfinished_work_seconds{controller="prometheus",name="prometheus_status"} 0
prometheus_operator_workqueue_unfinished_work_seconds{controller="prometheus-agent",name="prometheusagent"} 0
prometheus_operator_workqueue_unfinished_work_seconds{controller="prometheus-agent",name="prometheusagent_status"} 0
prometheus_operator_workqueue_unfinished_work_seconds{controller="thanos",name="thanosruler"} 0
prometheus_operator_workqueue_unfinished_work_seconds{controller="thanos",name="thanosruler_status"} 0
slashpai
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the following metrics on controller's workqueues:
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.