Chore: Refactor KumaSD#7697
Closed
mviswanathsai wants to merge 20 commits intoprometheus-operator:mainfrom
Closed
Conversation
AshwinSriram11
suggested changes
Jul 10, 2025
8f1e7a8 to
b5edf3b
Compare
b5edf3b to
7bdfb0c
Compare
nutmos
reviewed
Aug 16, 2025
7bdfb0c to
40d915a
Compare
| return fmt.Errorf("[%d]: %w", i, err) | ||
| } | ||
|
|
||
| if parsedURL.Host == "" { |
Contributor
There was a problem hiding this comment.
shouldn't this already be prevented by the API validation?
| return fmt.Errorf("[%d]: kuma SD server field must not be empty: %s", i, config.Server) | ||
| } | ||
|
|
||
| if parsedURL.Scheme != "http" && parsedURL.Scheme != "https" { |
| return fmt.Errorf("[%d]: invalid scheme '%s'. Only 'http' and 'https' are supported", i, parsedURL.Scheme) | ||
| } | ||
|
|
||
| if err := validateServer(string(config.Server)); err != nil { |
Contributor
|
superseded by #7966. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve CRD validations and test cases for Kuma SD. This PR picks up after #7379
Co-Author: @Dharma-09
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.