feat: added runtime validations for PrometheusAgent DaemonSet deployment model#7602
feat: added runtime validations for PrometheusAgent DaemonSet deployment model#7602slashexx wants to merge 41 commits intoprometheus-operator:mainfrom
Conversation
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
bd3cf82 to
67a0d57
Compare
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
b9e6fd2 to
fc49d9a
Compare
mviswanathsai
left a comment
There was a problem hiding this comment.
A few changes. You will also need to run make --always-make format generate
Co-authored-by: M Viswanath Sai <110663831+mviswanathsai@users.noreply.github.com>
Co-authored-by: M Viswanath Sai <110663831+mviswanathsai@users.noreply.github.com>
Co-authored-by: M Viswanath Sai <110663831+mviswanathsai@users.noreply.github.com>
4a277d3 to
79e8e65
Compare
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
79e8e65 to
f1bd9a8
Compare
|
Hi @mviswanathsai , this PR is still a bit WIP. I added the boilerplate tests last night have yet to work on it and make this better. I'll take a final look at this and then make the requested changes. |
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
55b0d2d to
278a625
Compare
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
b13d0ce to
1b94076
Compare
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
2972fa0 to
95f329a
Compare
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
…espaceSelector Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
|
The tests are failing. Change wise looks good may be need to update tests |
|
I am sorry about all the back and forth with this PR. We need to finalize and make the list of forbidden fields in this PR. Then we must make sure to make it clear in the proposal. |
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
mviswanathsai
left a comment
There was a problem hiding this comment.
Just one comment. Looks good to me otherwise.
CC: @slashpai
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
|
@mviswanathsai @slashpai apologies for the delay, all comments have been addressed ! |
|
@slashpai it's been a long while, this skipped my mind 😢 |
Co-authored-by: Jayapriya Pai <slashpai9@gmail.com>
Co-authored-by: Jayapriya Pai <slashpai9@gmail.com>
|
need to fix unit tests per the update too :) |
|
oh they failed :( On it ! |
Signed-off-by: Dhruv <136118444+slashexx@users.noreply.github.com>
|
@slashpai we're done ! |
|
@slashpai ptal :) |
|
@slashpai I think this should be gtg now |
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
This PR aims to add runtime validation testcases for PrometheusAgent DaemonSet deployment mode.
Fixes #7601
PR currently blocks issues #7741 and #7724
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.