fix(alertmanager, framework): use named ports for services#7517
Merged
simonpasquier merged 3 commits intoprometheus-operator:mainfrom Aug 19, 2025
Merged
Conversation
Contributor
|
ping @miinsun |
Contributor
Author
|
hello @yp969803 I’ve made the changes you suggested 😊 |
Contributor
|
LGTM! |
Contributor
|
@simonpasquier @mviswanathsai @slashpai merge request !! |
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
Can we add the values as const since the container port definitions need to use the same values?
d099208 to
68045ee
Compare
Use named ports instead of hard-coded port numbers in Alertmanager manifests and framework tests. Fixes prometheus-operator#7491 Signed-off-by: miinsun <kor3334@naver.com>
Signed-off-by: miinsun <kor3334@naver.com>
68045ee to
23da707
Compare
Signed-off-by: miinsun <kor3334@naver.com>
Contributor
Author
|
ping @simonpasquier — I’ve addressed your feedback. |
heliapb
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use named ports instead of hard-coded port numbers in Alertmanager manifests and framework tests.
Fixes #7491
Description
Since Prometheus and Thanos services already use named ports for their
targetPort, only Alertmanager needed to be updated. Additionally, some framework test examples specifiedtargetPortas an integer, so those have been changed to use the named port approach as well.Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
All existing unit tests pass successfully
Changelog entry