feat: add terminationGracePeriodSeconds field#7439
feat: add terminationGracePeriodSeconds field#7439simonpasquier merged 1 commit intoprometheus-operator:mainfrom
terminationGracePeriodSeconds field#7439Conversation
|
|
|
The e2e failure is unrelated, see #7455 |
This change adds the `terminationGracePeriodSeconds` field to the Alertmanager, Prometheus, PrometheusAgent and ThanosRuler CRDs. Closes prometheus-operator#3433 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
slashpai
left a comment
There was a problem hiding this comment.
lgtm just had a question for my understanding :)
| // Value must be non-negative integer. The value zero indicates stop immediately via | ||
| // the kill signal (no opportunity to shut down) which may lead to data corruption. | ||
| // | ||
| // Defaults to 120 seconds. |
There was a problem hiding this comment.
@simonpasquier curious why we didn't add default in API validation but as a constant?
There was a problem hiding this comment.
In general, we don't use default in the API definition so I wanted to stay consistent. Default values are returned in the response of the Kubernetes API which may cause issues with some clients (e.g. they might interpret the value being present as a need for another update).
There was a problem hiding this comment.
We do have // +kubebuilder:default: set for many fields do you think we should remove it then for them?
There was a problem hiding this comment.
I don't think that we can remove any of them for compatibility reasons but I'd rather not add more :)
Description
This change adds the
terminationGracePeriodSecondsfield to the Alertmanager, Prometheus, PrometheusAgent and ThanosRuler CRDs.Closes #3433
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.