feat: support pod spec field "enableServiceLinks" (#7383)#7384
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Mar 11, 2025
zoglam:main
Merged
feat: support pod spec field "enableServiceLinks" (#7383)#7384simonpasquier merged 1 commit intoprometheus-operator:mainfrom zoglam:main
simonpasquier merged 1 commit intoprometheus-operator:mainfrom
zoglam:main
Conversation
Contributor
simonpasquier
left a comment
There was a problem hiding this comment.
thanks! just a few comment otherwise LGTM.
test.yaml
Outdated
Contributor
There was a problem hiding this comment.
please remove this file.
| // +optional | ||
| DNSConfig *PodDNSConfig `json:"dnsConfig,omitempty"` | ||
| // Indicates whether information about services should be injected into pod's environment variables | ||
| // Is enabled by default |
Contributor
There was a problem hiding this comment.
Since it's a niche feature, I'd recommend to keep the description short. The same for the other CRDs.
Suggested change
| // Is enabled by default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR for issue - #7383
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
feat: support pod spec field "enableServiceLinks" (#7383)
Notes
Unit tests are provided