Also you need to add test to amcfg_test.go

It also requires a validation inside globalConfig to ensure alertmanager >= v0.28.0 https://github.com/prometheus/alertmanager/pull/3600/files

It also requires a validation inside globalConfig to ensure alertmanager >= v0.28.0 https://github.com/prometheus/alertmanager/pull/3600/files

Thanks for pointing out the changes @heliapb !

A little clarification on this part, we need to add a validation for the mutual exclusion (token, tokenFile and tokenID, tokenIDFile) as well right ?

Additionally, this includes adding apiUrl, token, tokenFile, tokenID, tokenIDFile to the globalConfig struct if I'm not wrong ?

It also requires a validation inside globalConfig to ensure alertmanager >= v0.28.0 https://github.com/prometheus/alertmanager/pull/3600/files

Thanks for pointing out the changes @heliapb !

A little clarification on this part, we need to add a validation for the mutual exclusion (token, tokenFile and tokenID, tokenIDFile) as well right ?

Additionally, this includes adding apiUrl, token, tokenFile, tokenID, tokenIDFile to the globalConfig struct if I'm not wrong ?

prometheus-operator/pkg/alertmanager/types.go

Lines 40 to 43 in b34cb97

	type globalConfig struct {
	// ResolveTimeout is the time after which an alert is declared resolved
	// if it has not been updated.
	ResolveTimeout *model.Duration `yaml:"resolve_timeout,omitempty" json:"resolve_timeout,omitempty"`

Hi @slashexx I would say so, you can take a look at the validations done for VictorOpsAPIKey | VictorOpsAPIKeyFile for example, as they follow a similar pattern

@slashpai would you mind taking a look as well ?

Hi @slashexx could you please rebase as the e2e test are failing due to an issue resolved.

Also you need to add test to amcfg_test.go

Hi @slashexx thanks for the work thus far I think we are close to be done, still as I said before the amcfg tests are missing.

Also you need to add test to amcfg_test.go

Hi @slashexx thanks for the work thus far I think we are close to be done, still as I said before the amcfg tests are missing.

Thanks for helping so far !

I'll add the test cases back like I did previously, but I thought we cleared that up since the Sanitize function for rocketchat handled the cases pretty well ?

gentle ping @slashpai @simonpasquier, ptal :)

Also you need to add test to amcfg_test.go

Hi @slashexx thanks for the work thus far I think we are close to be done, still as I said before the amcfg tests are missing.

Thanks for helping so far !

I'll add the test cases back like I did previously, but I thought we cleared that up since the Sanitize function for rocketchat handled the cases pretty well ?

prometheus-operator/pkg/alertmanager/amcfg_test.go

Lines 4124 to 4127 in 465bcba

	func TestSanitizeRocketChatConfig(t *testing.T) {
	logger := newNopLogger(t)
	versionRocketChatAllowed := semver.Version{Major: 0, Minor: 28}
	versionRocketChatNotAllowed := semver.Version{Major: 0, Minor: 27}

Hi @slashexx my bad I guess we already had discuss that but I forgot. Still if you could review the tests as the pipeline is failing.Thanks

Hi @slashexx my bad I guess we already had discuss that but I forgot. Still if you could review the tests as the pipeline is failing.Thanks

Hi I checked and the failing tests seem not to be related to my RocketChat changes ?

RocketChat ones are passing fine

Hi @slashexx my bad I guess we already had discuss that but I forgot. Still if you could review the tests as the pipeline is failing.Thanks

Hi I checked and the failing tests seem not to be related to my RocketChat changes ?

RocketChat ones are passing fine

Hi @slashexx could you tried to rebase again? Just run the tests from the main branch with go test -v ./pkg/alertmanager/ -run TestInitializeFromAlertmanagerConfig and all good.

@slashexx could you resolve the comments and rebase?

@mviswanathsai done 👍🏻

@simonpasquier the following check fails

2 errors:
		Documentation/getting-started/introduction.md:43: "https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/" not accessible even after retry; status code 0: context deadline exceeded (Client.Timeout or context cancellation while reading body)
		Documentation/getting-started/introduction.md:45: "https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors" not accessible even after retry; status code 0: net/http: request canceled (Client.Timeout or context cancellation while reading body)
2 errors:
		Documentation/platform/rbac-crd.md:14: "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#default-roles-and-role-bindings" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#default-roles-and-role-bindings": http2: timeout awaiting response headers
		Documentation/platform/rbac-crd.md:16: "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles": http2: timeout awaiting response headers
		Documentation/platform/troubleshooting.md:83: "https://kubernetes.io/docs/tasks/access-application-cluster/port-forward-access-application-cluster/" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/tasks/access-application-cluster/port-forward-access-application-cluster/": http2: timeout awaiting response headers
		Documentation/platform/exposing-prometheus-and-alertmanager.md:179: "https://kubernetes.io/docs/concepts/services-networking/ingress/" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/concepts/services-networking/ingress/": http2: timeout awaiting response headers
make: *** [Makefile:336: docs] Error 1

It doesn't fail locally for some reason. Rest of the PR should be gtg 🚀

@simonpasquier the following check fails

2 errors:
		Documentation/getting-started/introduction.md:43: "https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/" not accessible even after retry; status code 0: context deadline exceeded (Client.Timeout or context cancellation while reading body)
		Documentation/getting-started/introduction.md:45: "https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors" not accessible even after retry; status code 0: net/http: request canceled (Client.Timeout or context cancellation while reading body)
2 errors:
		Documentation/platform/rbac-crd.md:14: "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#default-roles-and-role-bindings" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#default-roles-and-role-bindings": http2: timeout awaiting response headers
		Documentation/platform/rbac-crd.md:16: "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles": http2: timeout awaiting response headers
		Documentation/platform/troubleshooting.md:83: "https://kubernetes.io/docs/tasks/access-application-cluster/port-forward-access-application-cluster/" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/tasks/access-application-cluster/port-forward-access-application-cluster/": http2: timeout awaiting response headers
		Documentation/platform/exposing-prometheus-and-alertmanager.md:179: "https://kubernetes.io/docs/concepts/services-networking/ingress/" not accessible even after retry; status code 0: Get "https://kubernetes.io/docs/concepts/services-networking/ingress/": http2: timeout awaiting response headers
make: *** [Makefile:336: docs] Error 1

It doesn't fail locally for some reason. Rest of the PR should be gtg 🚀

I have run-run the test and its passing. Its flaky on these links we need to look into separate