feat: Add a new Jira integration for alertmanager#7285
Open
dongjiang1989 wants to merge 22 commits intoprometheus-operator:mainfrom
Open
feat: Add a new Jira integration for alertmanager#7285dongjiang1989 wants to merge 22 commits intoprometheus-operator:mainfrom
dongjiang1989 wants to merge 22 commits intoprometheus-operator:mainfrom
Conversation
Signed-off-by: dongjiang <dongjiang1989@126.com>
slashpai
requested changes
Jan 20, 2025
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Member
Author
heliapb
reviewed
Feb 8, 2025
Co-authored-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
heliapb
previously approved these changes
Feb 10, 2025
|
Opsgenie is now read only, with jira being the replacement. Anything we can do to expedite this? Looks like @slashpai's changes have been addressed. |
Signed-off-by: dongjiang <dongjiang1989@126.com>
Member
Author
|
@slashpai @nicolastakashi Please re-check it. Rebase done. cc @jimethn Waiting it, thanks. |
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Contributor
@dongjiang1989 can you rebase? |
Signed-off-by: dongjiang <dongjiang1989@126.com>
Member
Author
Thanks @nicolastakashi |
9ada77e to
98492a3
Compare
98492a3 to
513b2f1
Compare
5 tasks
Contributor
|
@dongjiang1989 is this PR already abandoned? Can I continue working on it? |
isnt this already implemented with #7315 ? edit: seems like this is still required |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add a new JIRA integration for alertmanager.
ref: prometheus/alertmanager#3590
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.