Fix Broken Links to Ingress Guide and Add Prometheus & Alertmanager Exposure Guide#7170
Conversation
AshwinSriram11
left a comment
There was a problem hiding this comment.
Sorry for the late review @Dharma-09. LGTM 👍 Just to make sure that everything works well, can you make another PR in the website repo to show the website preview?
|
Thanks for the review @AshwinSriram11 👍 I’ll create a follow-up PR in the website repo. |
AshwinSriram11
left a comment
There was a problem hiding this comment.
I don't think you need to add these new changes you made in the recent commit. What I meant was to change the source path in the synchronization.sh file in the website repo like I mentioned in that commit.
Look at this example: prometheus-operator/website@e71a061#:~:text=git%20clone%20https,repos/kube%2Dprometheus
When the PR in the main repo was merged, I changed it back to the original source path. This way, you can check whatever changes you make in the docs are working neatly on the website. |
|
I was a bit confused earlier. Thanks for clarifying! |
|
Can you revert to commit with only changes to docs? We don't want any changes other than what we had before. |
This reverts commit 66da769.
|
@Dharma-09 LGTM 👍 Just made a commit in the website repo and the preview works fine |
|
Let's wait for all the tests to pass and merge this PR and then you can change the path in the synchronization file to the original path and we are done. |
|
@nicolastakashi I have reviewed it and LGTM. PTAL |
|
Thank you, @AshwinSriram11, for your help! |
Description
Updates all broken links to the Ingress Guide throughout the website.
Replaces non-functional links with a working reference to the Prometheus & Alertmanager Exposure Guide.
Issues
#6978
prometheus-operator/website#116
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.