Refactor EC2 Service discovery#6744
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Aug 14, 2024
Merged
Conversation
Contributor
Author
|
PTAL @slashpai |
slashpai
reviewed
Jul 10, 2024
a3b0d2c to
ac2d27f
Compare
ecdc786 to
227fdfa
Compare
Contributor
Author
@simonpasquier is this possibly a consequence of #6789? |
Contributor
|
That's another issue to be solved unfortunately. |
227fdfa to
39cea08
Compare
Contributor
There was a problem hiding this comment.
thoughts for later: if we keep adding validation tests for ScrapeConfig (which is def. good!), it might be more readable to split into sub-test functions for each SD.
Contributor
Author
There was a problem hiding this comment.
I agree. Let me make a PR right after this gets merged to make that change.
39cea08 to
d97533a
Compare
This was referenced Dec 17, 2024
Closed
Closed
This was referenced Dec 17, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors any inconsistencies in the EC2 service discovery. This PR also adds HTTP client configuration (
Auth,OAuth2,BasicAuth,EnableHTTP,AllowRedirects) fields that have been part of EC2 SD since Prometheusv2.41.0.Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.