ScrapeConfig CRD: Proposal For Extending The CRD Surface #6634
ScrapeConfig CRD: Proposal For Extending The CRD Surface #6634simonpasquier merged 5 commits intoprometheus-operator:mainfrom
Conversation
simonpasquier
left a comment
There was a problem hiding this comment.
This is a good start!
d76af43 to
4245c80
Compare
ArthurSens
left a comment
There was a problem hiding this comment.
Good start, it's great that we're already thinking about graduation tasks even though the GSoC proposal was only about adding new SDs to the scrape config! I really like that you're taking one step further (@xiu will be proud to see this 😛)
There are opportunities to improve the proposal, I got the impression that you wrote the proposal with your hands tied by your GSoC project and it turned the proposal too broad. Is this proposal about ScrapeConfig graduation or is it about implementing missing fields? We already know that we want to eventually implement all SDs and missing fields, there's no confusion about it and implementing them is straightforward.
Graduating the CRD is also something that we already know we want, but the path to it is not straightforward, therefore, writing a proposal is super beneficial to find consensus in our community.
My advice here would be to refactor the proposal, focusing on how the graduation path looks like. If implementing a set of SDs is a requirement, let's be clear about which ones and why. It's ok to not have SDs as requirement, in this case, we can just say so :) It would be nice to clarify which tasks, e.g. testing, SD implementation, refactoring Monitor CRDs, are planned to each graduation phase
f6b0bf5 to
e313307
Compare
slashpai
left a comment
There was a problem hiding this comment.
Looks good to me overall, a few nits
|
|
||
| #### Requirements for Graduation | ||
|
|
||
| I feel that we can graduate the CRD to beta when the following milestones are all achieved: |
There was a problem hiding this comment.
| I feel that we can graduate the CRD to beta when the following milestones are all achieved: | |
| We propose to graduate the CRD to beta when the following milestones are all achieved: |
360e829 to
1b8c6a1
Compare
|
Hey! any further comments? |
simonpasquier
left a comment
There was a problem hiding this comment.
Could you also address the other comments? Thanks!
|
|
||
| ## Non-Goals | ||
|
|
||
| - Implementing all 28 Service Discovery configurations immediately. |
There was a problem hiding this comment.
| - Implementing all 28 Service Discovery configurations immediately. | |
| - Implementing the 28 Service Discovery configurations currently supported by Prometheus. |
1b8c6a1 to
7359c40
Compare
38e1af1 to
e975790
Compare
simonpasquier
left a comment
There was a problem hiding this comment.
I've reviewed the tiers list and made some suggestions. Could you also review @slashpai comments and replace "I ..." by "We ..."?
d14beba to
67002f2
Compare
a70719a to
d0d9066
Compare
|
PTAL @simonpasquier @slashpai |
simonpasquier
left a comment
There was a problem hiding this comment.
Almost good! I'll commit my suggestions and merge. If I was wrong, please push an update.
|
@mviswanathsai my changes don't pass the doc linter. Would you mind fixing the format and I'll merge :) |
…o beta Signed-off-by: mviswanathsai <mviswanath.sai.met21@itbhu.ac.in>
39b760c to
4196549
Compare
|
🥳 |
|
Woah, finally! |
Description
Proposal for extending the ScrapeConfig API surface to pave the way for graduation to
v1beta1.Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.