-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
Description
Is there an existing issue for this?
- I have searched the existing issues
What happened?
Description
The scrapeFallbackProtocol field in PrometheusSpec is invalid, this is not a global configuration parameter as per https://prometheus.io/docs/prometheus/latest/configuration/configuration/
It's only valid on scrape_config.
This might be better as part of the ScrapeClass spec, then you can create a default scrape class that sets this value everywhere!
Alternatively the current field needs to affect every generated scrape job rather than go into the global config
Steps to Reproduce
Set spec.scrapeFallbackProtocol to anything in a Prometheus resource.
Expected Result
Valid Prometheus config yaml is created
Actual Result
Prometheus (v3.0.1) reports an error reloading configuration
time=2024-12-16T01:29:12.923Z level=ERROR source=main.go:1162 msg="Error reloading config" err="couldn't load configuration (--config.file=\"/etc/prometheus/config_out/prometheus.env.yaml\"): parsing YAML file /etc/prometheus/config_out/prometheus.env.yaml: yaml: unmarshal errors:\n line 3: field fallback_scrape_protocol not found in type config.plain"
Prometheus Operator Version
0.79.0Kubernetes Version
1.31.2Kubernetes Cluster Type
EKS
How did you deploy Prometheus-Operator?
helm chart:prometheus-community/kube-prometheus-stack
Manifests
No response
prometheus-operator log output
N/AAnything else?
No response
Reactions are currently unavailable