ignore timestamps from cadvisor metrics#695
Merged
brancz merged 2 commits intoprometheus-operator:masterfrom Oct 2, 2020
Merged
ignore timestamps from cadvisor metrics#695brancz merged 2 commits intoprometheus-operator:masterfrom
brancz merged 2 commits intoprometheus-operator:masterfrom
Conversation
Member
Author
|
Workaround fix for google/cadvisor#2526 |
Collaborator
|
Ultimately this still needs to be fixed in cAdvisor but I'm happy to move ahead with this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over a year ago cAdvisor v0.33.0 started to include timestamps in their metrics. This change was included in k8s 1.18 and kubelet started to do the same on
/metrics/cadvisorendpoint. This can lead to stale data being ingested as can be observed for example when the container is OOMKilled (as in the image below).This issue was observed by one of prometheus users and reported on prometheus IRC. The proposed fix was to discard timestamps and was later confirmed to be working.
Creating it now, when I have data from prometheus IRC and don't need to reproduce everything.