fix(manifests): exclude 'config-reloader' container from 'Alertmanage…#2754
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Oct 8, 2025
Merged
Conversation
Contributor
|
Thanks for the PR! The manifests are generated from the jsonnet sources so the change needs to go there: I suggest to add |
085e8c8 to
e67643e
Compare
Contributor
Author
|
Thanks for guiding me. Not sure if you want to have this in the same string or split up. |
Contributor
Author
|
@simonpasquier are the failing tests automatically rendered when merging to main or shall I added/fix them manually? |
Contributor
|
We have some tests which are flaky but they aren't required to merge. |
Contributor
Author
|
I'm asking because I can see e.g. this change: |
Contributor
|
Ha! you need to run |
…rClusterDown' alert When Prometheus is not able to scrape the config-reloader but able to scrape Alertmanager itself, the alert would trigger a critical. Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
Contributor
Author
|
Should look better now |
Contributor
Author
|
I think is not on me. Thanks 🚀 |
1e456f8
into
prometheus-operator:main
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rClusterDown' alert
Description
When Prometheus is not able to scrape the config-reloader but able to scrape Alertmanager itself, the alert would trigger a critical.
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry