Alertmanager: Select AlertmanagerConfig CRs within its own namespace by default#2747
Merged
simonpasquier merged 2 commits intoprometheus-operator:mainfrom Oct 8, 2025
Conversation
Contributor
|
Can we introduce a config parameter that would let specify the alertmanagerConfigSelector? |
Contributor
Author
OK. I'll do it. |
Contributor
Author
|
done. |
6828741
into
prometheus-operator:main
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the Alertmanager CR to automatically select AlertmanagerConfig CRs within its own namespace by default.
Currently, Alertmanager
spec.alertmanagerConfigSelectoris unspecified by default, which means no AlertmanagerConfigs are selected by default.On the other hand, Prometheus
.spec.serviceMonitorSelectoris{}by default, meaning it automatically selects ServiceMonitor CRs within its own namespace by default.Users are confused by this discrepancy in default configurations between Prometheus CRs and Alertmanager CRs.
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry