examples: "changing-default-rules" doesn't remove all kubernetesControlPlane prometheusRules.#2718
Merged
simonpasquier merged 1 commit intoprometheus-operator:mainfrom Aug 25, 2025
Conversation
The :: was overriding the visibility, causing no output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prometheusRule+::was overriding the visibility, causing no output.Description
examples/changing-default-rules.libsonnetusesprometheusRule+::, but this changes the visibility of the field used to actually expose the createdPrometheusRuleobjects. See:kube-prometheus/jsonnet/kube-prometheus/components/k8s-control-plane.libsonnet
Lines 52 to 64 in 3c832a1
Using
prometheusRule+:instead works as expected.Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.