Fix port allocation for node-exporter#2627
Merged
philipgough merged 2 commits intoprometheus-operator:mainfrom May 16, 2025
Merged
Fix port allocation for node-exporter#2627philipgough merged 2 commits intoprometheus-operator:mainfrom
philipgough merged 2 commits intoprometheus-operator:mainfrom
Conversation
|
You meant
Right I can confirm this fixes the issue, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The daemonset for the node exporter is statically invalid. It assigns port 9100 both to the node-exporter container and to the kube-rbac-proxy container.
This results in the following behavior at runtime:
This change is somewhat risky as we've been (so far) rolling out node-exporter with no kube-rbac-proxy, and would now unmasks any bugs in the kube-rbac-proxy integration.
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Activate kube-rbac-proxy for node-exporter.