feat: support more specific prefixes in ?collect parameter#387
Conversation
Signed-off-by: Antoine Deschênes <antoine.deschenes@linux.com>
594fcb3 to
3de3928
Compare
|
cc: @SuperQ @kgeckhart |
kgeckhart
left a comment
There was a problem hiding this comment.
Other question: is there a technical reason that would prevent from having a flag disabling prefix filtering in ?collect?
The configuration could be a bit confusing if you have to provide metric prefixes that are completely ignored when calling collect.
Looks like that feature was already implemented along another change and then reverted through PR #316
though the reason for the revert seems to be that the main handler was removed, which caused a regression to aggregate-deltas #315
You're right, this implementation should be okay because it's not changing any of the handler functionality directly.
Thanks for doing this! I'll see if I can resolve ?collect being incompatible with aggregate deltas separately.
Oh, by that I mean that |
This changes the
?collectparameter filter to allow more specific prefixes than those setup in the metrics-prefixes.Example use cases:
redis.googleapis.com/stats/memory/usage_ratioprefix set in the?collectconfig of dozens of projects.Now, I'd like to enable the
redis.googleapis.com/stats/memory/usagemetric in the stackdriver_exporter metric prefixes, but since it conflicts with the more-specificredis.googleapis.com/stats/memory/usage_ratiometric name, the exporter will stop accepting the?collectparam I've set in other configurations.redis.googleapis.commetrics, but only collect 1 or 2 metrics with?collect. Currently, the prefixes have to be exact matches so this is not possible without the proposed change.To test:
Other question: is there a technical reason that would prevent from having a flag disabling prefix filtering in
?collect?