Replace comma-delimited string flags with repeatable flags#355
Merged
kgeckhart merged 2 commits intoprometheus-community:masterfrom Oct 7, 2024
Merged
Replace comma-delimited string flags with repeatable flags#355kgeckhart merged 2 commits intoprometheus-community:masterfrom
kgeckhart merged 2 commits intoprometheus-community:masterfrom
Conversation
904c473 to
46c70ae
Compare
Contributor
|
I like it, mind doing a rebase? |
Signed-off-by: Tommy Li <tommy.li@clickhouse.com>
Contributor
Author
|
@SuperQ Done, thanks |
Contributor
|
I wonder if it would be worth keeping the original flag as-is, and append the |
SuperQ
requested changes
Sep 1, 2024
Signed-off-by: Tommy Li <tommy.li@clickhouse.com>
c472c1b to
ac0a08e
Compare
SuperQ
approved these changes
Oct 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
The original issue is pretty old but the feature request still holds up, I too find it more ergonomic to manage repeatable flags rather than a large comma-delimited string. As suggested in the issue, I also changed
metrics-type-prefixesto justmetrics-prefixes