Merged
Conversation
Contributor
SuperQ
commented
May 25, 2023
- [FEATURE] cache descriptors to reduce API calls cache descriptors to reduce API calls #218
Contributor
Author
|
CC @fbs |
Nexucis
approved these changes
May 25, 2023
6999f22 to
561053d
Compare
Add exporter-toolkit to handle flags and landing page. * Update README. Signed-off-by: SuperQ <superq@gmail.com>
* [FEATURE] cache descriptors to reduce API calls #218 Signed-off-by: SuperQ <superq@gmail.com>
taisph
reviewed
May 26, 2023
| listenAddress = kingpin.Flag( | ||
| "web.listen-address", "Address to listen on for web interface and telemetry.", | ||
| ).Default(":9255").String() | ||
| toolkitFlags = webflag.AddFlags(kingpin.CommandLine, ":9225") |
There was a problem hiding this comment.
Was the port change from 9255 to 9225 done in error?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.