Fix UTF-8 label names display in UI#710
Merged
beorn7 merged 2 commits intoprometheus:masterfrom Dec 18, 2024
Merged
Conversation
Signed-off-by: Federico Torres <federico.torres@grafana.com>
Signed-off-by: Federico Torres <federico.torres@grafana.com>
beorn7
approved these changes
Dec 18, 2024
Member
beorn7
left a comment
There was a problem hiding this comment.
Nice, thank you.
I'll take this as a reason to cut a new PGW release. Hopefully still this year. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #689, this PR fixes how label names containing UTF-8 characters are displayed in the Pushgateway UI, double-quoting the label names and escaping double quotes within them.
Related to #623