Skip to content

Log when liveness probes fails due to full write queue#645

Merged
beorn7 merged 3 commits intoprometheus:masterfrom
vthemelis:log-at-failed-liveness-checks
Jun 6, 2024
Merged

Log when liveness probes fails due to full write queue#645
beorn7 merged 3 commits intoprometheus:masterfrom
vthemelis:log-at-failed-liveness-checks

Conversation

@vthemelis
Copy link
Contributor

No description provided.

Signed-off-by: Vasilis Themelis <vdthemelis@gmail.com>
@vthemelis vthemelis force-pushed the log-at-failed-liveness-checks branch from e536245 to c1cb032 Compare May 29, 2024 21:24
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looks good in general, just some details to note.

Signed-off-by: Björn Rabenstein <github@rabenste.in>
@beorn7
Copy link
Member

beorn7 commented Jun 6, 2024

To get this into the next release, I'll apply the suggested changes directly here in the PR.

Signed-off-by: Björn Rabenstein <github@rabenste.in>
@beorn7 beorn7 merged commit 44fa056 into prometheus:master Jun 6, 2024
@vthemelis vthemelis deleted the log-at-failed-liveness-checks branch June 6, 2024 19:58
@SuperQ SuperQ mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants