Skip to content

Add image build for s390x architecture#537

Merged
beorn7 merged 1 commit intoprometheus:masterfrom
modassarrana89:master
Mar 13, 2023
Merged

Add image build for s390x architecture#537
beorn7 merged 1 commit intoprometheus:masterfrom
modassarrana89:master

Conversation

@modassarrana89
Copy link

Updated Makefile for adding s390x architecture
Updated .dockerignore file for s390x

@modassarrana89
Copy link
Author

Please approve post review

Signed-off-by: root <root@m13lp76.lnxero1.boe>
@beorn7
Copy link
Member

beorn7 commented Mar 13, 2023

I guess this should just work. It's similar to prometheus/prometheus#6486 .

@simonpasquier you reviewed that PR back in the days. Do you see any concerns here?

I'll merge for now, but wait a bit before cutting a release.

@beorn7 beorn7 merged commit 9622e44 into prometheus:master Mar 13, 2023
@beorn7
Copy link
Member

beorn7 commented Mar 13, 2023

For posteriority:

For the push to quay.io to work, I had to manually create the repository https://quay.io/repository/prometheus/pushgateway-linux-s390x

@modassarrana89
Copy link
Author

Pushgateway tar file is already s390x & same is being used in Quay . So this change was Just to build the image for pushgateway for s390x . This build is not for Quay

@modassarrana89
Copy link
Author

Thanks for the update . I can see s390x image for master release . Is there any plan to keep it as part of other release ex latest , etc

@beorn7
Copy link
Member

beorn7 commented Mar 14, 2023

I will cut a new release in the next days, which will get an image than for an official release.

I do not plan to add images to older releases. There haven't been any invasive changes in the PGW for years, so I don't anticipate substantial need to run older versions instead of the current one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants