Merged
Conversation
Member
Author
|
I'll squash with DCO after LGTM |
bwplotka
approved these changes
Mar 5, 2026
Member
bwplotka
left a comment
There was a problem hiding this comment.
Amazing, some nits but otherwise LGTM 👍🏽
990ca85 to
1fa9b74
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Owen Williams <owen.williams@grafana.com>
1fa9b74 to
cefa68b
Compare
bwplotka
reviewed
Mar 6, 2026
bwplotka
approved these changes
Mar 6, 2026
Member
bwplotka
left a comment
There was a problem hiding this comment.
One thing, but we can fix later 👍🏽
Signed-off-by: Owen Williams <owen.williams@grafana.com>
Member
Author
|
easy fix. merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude + me edits to PROM-60 to bring it up to date with current naming conventions, implementations, and plans.