Adding changes to support s390x#107
Merged
sdurrheimer merged 1 commit intoprometheus:masterfrom Sep 24, 2018
Merged
Conversation
609f563 to
6feca04
Compare
6feca04 to
506b8a3
Compare
SuperQ
reviewed
Sep 19, 2018
cmd/crossbuild.go
Outdated
| "openbsd/arm": {"openbsd/armv7"}, | ||
| "netbsd/arm": {"netbsd/armv6", "netbsd/armv7"}, | ||
| } | ||
| defaultS390XPlatforms = []string{ |
Member
There was a problem hiding this comment.
Do we want to call this defaultS390Platforms, just in case we ever add support for both s390 and s390x? Or is that silly?
Contributor
Author
There was a problem hiding this comment.
Maybe we can do away with the default? I guess s390xPlatforms is already used in method runCrossbuild.
Dont think we would add support for s390.
Member
There was a problem hiding this comment.
No, it should be defaultS390Platforms. It also needs to be moved up to below defaultMIPSPlatforms.
Member
|
Don't forget to update |
Signed-off-by: duane-ibm <duaned@us.ibm.com>
506b8a3 to
b78b370
Compare
Contributor
Author
|
Done. Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes for building promu on s390x. Also modified the crossbuild.go to add s390x support.
Can someone please review the changes?