Skip to content

bump codemirror-promql to 0.17.0#9183

Merged
brancz merged 1 commit intoprometheus:release-2.29from
Nexucis:feature/bump-cmp
Aug 10, 2021
Merged

bump codemirror-promql to 0.17.0#9183
brancz merged 1 commit intoprometheus:release-2.29from
Nexucis:feature/bump-cmp

Conversation

@Nexucis
Copy link
Member

@Nexucis Nexucis commented Aug 10, 2021

Signed-off-by: Augustin Husson husson.augustin@gmail.com

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis requested a review from juliusv as a code owner August 10, 2021 09:49
@juliusv
Copy link
Member

juliusv commented Aug 10, 2021

@brancz Needs to decide on this as the 2.29 release shepherd, since this PR is against the 2.29 release branch.

@roidelapluie
Copy link
Member

Is this an update to add present_over_time?

@Nexucis
Copy link
Member Author

Nexucis commented Aug 10, 2021

yes totally @roidelapluie. Linter / autocomplete and highlight of present_over_time

@Nexucis
Copy link
Member Author

Nexucis commented Aug 10, 2021

forgot to mention it, sry about that

@brancz
Copy link
Member

brancz commented Aug 10, 2021

So I didn't expect this release to take this long, and I'm going to be less connected internet-wise for the rest of the week. I talked to @roidelapluie and since this is just a frontend change we'd be ok with including this and cutting the final release with it. Should there be any unexpected problems, then @roidelapluie would take over cutting a patch release until the beginning of next week.

@juliusv
Copy link
Member

juliusv commented Aug 10, 2021

Sounds good to me too, the risk should be minimal (just maybe try that it works 😆).

@brancz
Copy link
Member

brancz commented Aug 10, 2021

haha yes sorry forgot to mention that it will of course be tested

@brancz brancz merged commit 338244d into prometheus:release-2.29 Aug 10, 2021
@Nexucis Nexucis deleted the feature/bump-cmp branch August 10, 2021 12:22
@Nexucis
Copy link
Member Author

Nexucis commented Aug 10, 2021

cool thanks to all of view !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants