Merged
Conversation
Member
|
Could we have #9119 as well? |
Member
Author
|
Added |
roidelapluie
reviewed
Aug 4, 2021
CHANGELOG.md
Outdated
| * [BUGFIX] Fix timestamp handling in OpenMetrics parser. #9008 | ||
| * [BUGFIX] Fix potential duplicate metrics in `/federate` endpoint when specifying multiple matchers. #8885 | ||
| * [BUGFIX] Fix server configuration and validation for authentication via client cert. #9123 | ||
| * [BUGFIX] Fix start and end keywords masking label and metric names when using PromQL `@` modifier. #9119 |
Member
There was a problem hiding this comment.
Suggested change
| * [BUGFIX] Fix start and end keywords masking label and metric names when using PromQL `@` modifier. #9119 | |
| * [BUGFIX] Allow `start` and `end` again as label names in PromQL queries. They were disallowed since the introduction of @ timestamp feature. #9119 |
Maybe that is more clear?
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
roidelapluie
approved these changes
Aug 4, 2021
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roidelapluie @SuperQ @codesome @juliusv