Add a compatibility note for macOS users.#9150
Merged
brancz merged 1 commit intoprometheus:release-2.29from Aug 4, 2021
Merged
Add a compatibility note for macOS users.#9150brancz merged 1 commit intoprometheus:release-2.29from
brancz merged 1 commit intoprometheus:release-2.29from
Conversation
LeviHarrison
reviewed
Aug 4, 2021
CHANGELOG.md
Outdated
Comment on lines
+4
to
+5
| this is the last Prometheus release that supports macOS 10.12 Sierra and | ||
| previous versions. |
Contributor
There was a problem hiding this comment.
This is not technically true, Go 1.15 dropped support for anything before macOS 10.12 Sierra, and therefore this release is the last one to support 10.12 specifically.
This could be confusing to users who see this in the changelog and assume they can use 2.29 on their macOS <10.12, but it's not really a huge issue.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
brancz
approved these changes
Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu