promtool: Add debug flag for rule tests#8349
Closed
dgl wants to merge 1 commit intoprometheus:mainfrom
Closed
Conversation
Member
|
cc @dgl are you willing to rebase this pull request? Thanks! |
Member
Author
|
@roidelapluie I'd totally forgotten about this one, but yes, this is still useful! |
This makes it print out the tsdb state (both input_series and rules that are run) at the end of a test, making reasoning about tests much easier. Signed-off-by: David Leadbeater <dgl@dgl.cx>
Member
bwplotka
approved these changes
Feb 1, 2024
| } | ||
|
|
||
| func ruleUnitTest(filename string, queryOpts promql.LazyLoaderOpts) []error { | ||
| func ruleUnitTest(debug bool, filename string, queryOpts promql.LazyLoaderOpts) []error { |
Member
There was a problem hiding this comment.
hm, should we move this bool to the end, it feels like not a main parameter
Member
|
Superseded by #15196 . Took these commits and merged main and resolved conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it print out the tsdb state (both input_series and rules that
are run) at the end of a test, making reasoning about tests much easier.
Signed-off-by: David Leadbeater dgl@dgl.cx