promtool: Show more human readable got/exp output#8064
Merged
dgl merged 2 commits intoprometheus:mainfrom Oct 28, 2021
Merged
Conversation
Member
Author
|
cc: @simonpasquier |
e55d932 to
a4ad4bb
Compare
Member
Author
|
@simonpasquier would you be able to have a look at this? |
a4ad4bb to
3d55f70
Compare
3d55f70 to
5a8e5b0
Compare
5a8e5b0 to
a2bcfd4
Compare
Avoid using %#v, nothing needs to parse this, so escaping " and so on leads to hard to read output. Add new lines, number and indentation to each alert series output. Signed-off-by: David Leadbeater <dgl@dgl.cx>
Member
Author
|
@roidelapluie PTAL, I think I fixed your last comment. |
Member
|
I'll add this to my TODO |
Member
Author
|
@roidelapluie ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it much easier to see how many alerts are firing, rather than having to scan through a line of text looking for a
,. It probably makes #7883 obsolete too.The output now looks something like this: