tsdb: Do not reuse the same crc32 hash between Chunk() calls#6514
Closed
roidelapluie wants to merge 1 commit intoprometheus:masterfrom
Closed
tsdb: Do not reuse the same crc32 hash between Chunk() calls#6514roidelapluie wants to merge 1 commit intoprometheus:masterfrom
roidelapluie wants to merge 1 commit intoprometheus:masterfrom
Conversation
Member
Author
|
Now working on a test. |
9394686 to
9c4eef2
Compare
The same crc32 object was called concurrently between chunks. As this object is only used in that function, create a new one each time the function is run. See prometheus#6512 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Member
Author
|
I am not sure that it is enough ; now it runs fine if r.Chunk(chkExp.Ref) is called concurrently with the same chkExp.Ref but not otherwise. |
Member
Author
|
more-complex-than-it-looks |
Member
|
Thanks for starting this up. Looks like we are also reusing |
This was referenced Dec 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same crc32 object was called concurrently between chunks. As this
object is only used in that function, create a new one each time the
function is run.
See #6512
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu