Bump prometheus/common to v0.3.0#5344
Merged
brian-brazil merged 3 commits intoprometheus:masterfrom Apr 10, 2019
Merged
Conversation
Contributor
|
We're meant to be doing versioning on common now, so we should create a tag&release over there. There are other common changes that we'll want that should make it into 2.9. |
Member
Author
|
Ack. I'll keep the PR open and update it once you cut a release of common. |
Member
|
Do you need help here @simonpasquier ? |
Member
Author
|
@roidelapluie no, as I wrote in the previous comment, we need to wait for a release of prometheus/common... |
This change bumps github.com/prometheus/common to include prometheus/common#173 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
ce39c3d to
93e3fac
Compare
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4155
Closes #5394
This change bumps github.com/prometheus/common to include prometheus/common#173