Support basic_auth in marathon_sd_config. Closes #3090#3238
Closed
MarcinCiura wants to merge 1 commit intoprometheus:masterfrom
MarcinCiura:issue-3090/support-basic_auth-in-marathon_sd_config
Closed
Support basic_auth in marathon_sd_config. Closes #3090#3238MarcinCiura wants to merge 1 commit intoprometheus:masterfrom MarcinCiura:issue-3090/support-basic_auth-in-marathon_sd_config
MarcinCiura wants to merge 1 commit intoprometheus:masterfrom
MarcinCiura:issue-3090/support-basic_auth-in-marathon_sd_config
Conversation
Author
|
Pinging @brian-brazil as service discovery is his focus area. |
Author
|
Pinging also @fabxc as service discovery is his focus area. |
Contributor
|
@brian-brazil looks like a dupe of #1745 |
Contributor
|
As per the other PR, this should use HTTPClientConfig rather than doing it's own thing auth wise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.