Merged
Conversation
SuperQ
reviewed
Feb 19, 2026
Makefile
Outdated
| # Needs to be defined before including Makefile.common to auto-generate targets | ||
| DOCKER_ARCHS ?= amd64 armv7 arm64 ppc64le riscv64 s390x | ||
| DOCKER_ARCHS ?= amd64 armv7 arm64 ppc64le riscv64 s390x | ||
| DOCKER_ARCHS_distroless := $(filter-out riscv64,$(DOCKER_ARCHS)) |
Member
There was a problem hiding this comment.
We need to fix this in Makefile.common.
Member
There was a problem hiding this comment.
Should we do it now or keep the hack for now?
bwplotka
approved these changes
Feb 19, 2026
Member
bwplotka
left a comment
There was a problem hiding this comment.
Shall we fix Makefile.common instead?
But overall I ok with this quick fix to unblock, just let's add an issue to reconsider RISCV back
Member
roidelapluie
approved these changes
Feb 19, 2026
Member
roidelapluie
left a comment
There was a problem hiding this comment.
I am fine with either this or #18110
0463e61 to
ab88906
Compare
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
ab88906 to
decde0b
Compare
Member
Author
|
I merged #18110 and turned this PR into cutting the rc.1 instead |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocking the 3.10 release since
gcr.io/distroless/static-debian13:nonroot-riscv64does not exist. This PR attempts to remove theriscv64from the build process.Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?