Merged
Conversation
14d7504 to
8c1b4b0
Compare
Collaborator
Author
|
@SuperQ @sysadmind would you be able to review when you have a minute? |
Signed-off-by: matt-gp <small_minority@hotmail.com>
8c1b4b0 to
96a87a0
Compare
Member
|
Do we really need that much request concurrency here? That's slightly concerning on its own. |
Collaborator
Author
|
Happy to lower it if needs be, I've been trying to find what the actual limits are but not found them anywhere. For reference ECS allows upto 20 on a lot it's API. Should we lower it down to something like 3, or should we go even lower? |
Member
|
Ah, yea, I hadn't noticed that ECS also did this. I guess I'm just surprised by the need for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes some optimisations to the MSK role.
These optimisations include:
listNodesmethod (previously used wait groups), this is to mitigate the possibility of hitting rate limits if someone had a lot of clusters.describeClustersmethod (previously used wait groups), this is to mitigate the possibility of hitting rate limits if someone had a lot of clusters.Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?