Update Go dependencies for v3.10 release#18024
Merged
Conversation
4c397ee to
4fe1132
Compare
Member
|
otel dependencies fail; probably a version mismatch |
e8eb9e1 to
2f678b7
Compare
Member
Author
|
@roidelapluie I have fixed the issues now |
roidelapluie
approved these changes
Feb 10, 2026
Member
roidelapluie
left a comment
There was a problem hiding this comment.
LGTM but needs rebase now :)
Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>
Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>
2f678b7 to
847e474
Compare
…dentialsFile Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>
codesome
commented
Feb 10, 2026
| } | ||
| opts = append(opts, option.WithCredentials(creds)) | ||
| opts = append(opts, option.WithAuthCredentialsFile(option.ServiceAccount, cfg.CredentialsFile)) | ||
| } else { |
Member
Author
There was a problem hiding this comment.
For all the new review tags, it is for this change. Lint complained about deprecation.
Member
Author
|
I am merging it for now since the last commit is small and harmless. If you have any comments/concerns I will fix it in a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Go deps in preparation for v3.10 release.
Ran
make update-all-go-depsNote: I had to manually add
replace cloud.google.com/go => cloud.google.com/go v0.123.0om 2 places because they decided to break apart the module into smaller modules and it was creatingambiguous importerrors.Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?