otlptranslator: fix silently swallowed error in addSumNumberDataPoints#17954
Merged
aknuds1 merged 1 commit intoprometheus:mainfrom Jan 28, 2026
Merged
Conversation
The createAttributes error was incorrectly returning nil instead of err, causing errors to be silently discarded. This could lead to silent data loss for sum metrics during OTLP ingestion. Fixes prometheus#17953 Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
ArthurSens
approved these changes
Jan 28, 2026
Contributor
Author
|
@ArthurSens Done, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Fixes #17953
Does this PR introduce a user-facing change?
Description
The
createAttributeserror inaddSumNumberDataPointswas incorrectly returningnilinstead oferr, causing errors to be silently discarded. This was introduced in #16951 during a refactor.This fix aligns the error handling with
addGaugeNumberDataPointsin the same file, which correctly returns the error.