Merged
Conversation
bwplotka
approved these changes
Jan 20, 2026
Contributor
Author
|
Asked maintainers to re-run the jobs few more times to be 100% sure if tests are fixed. |
bwplotka
requested changes
Jan 20, 2026
Member
bwplotka
left a comment
There was a problem hiding this comment.
Looks like it's not about timeouts here 🤔
d1216d5 to
16929c7
Compare
Contributor
Author
Yes, there was a bug were tests were running with sendloops but no AMs in the sets. |
16929c7 to
f09f3a6
Compare
machine424
reviewed
Jan 20, 2026
machine424
reviewed
Jan 20, 2026
f09f3a6 to
2188a11
Compare
Contributor
Author
|
Still failing on Windows... |
Contributor
Author
|
Let's run |
47214c1 to
fc36ad6
Compare
bwplotka
reviewed
Jan 21, 2026
Member
bwplotka
left a comment
There was a problem hiding this comment.
Amazing work and thank you!
Added some idea to avoid that inconsistent check in prod code, as per @machine424 comment.
machine424
reviewed
Jan 21, 2026
Member
machine424
left a comment
There was a problem hiding this comment.
some suggestions and questions
fc36ad6 to
1c6bd74
Compare
This was referenced Jan 21, 2026
1c6bd74 to
db2f0e7
Compare
bwplotka
reviewed
Jan 21, 2026
db2f0e7 to
48b328a
Compare
auto-merge was automatically disabled
January 22, 2026 08:26
Head branch was pushed to by a user without write access
7ff0898 to
5e9c8fd
Compare
Add a helper function to set up AlertmanagerSets. Fix all flaky tests. Signed-off-by: Siavash Safi <siavash@cloudflare.com>
0550b65 to
749cc22
Compare
siavashs
commented
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Add a helper function to set up AlertmanagerSets.
Fix all flaky tests.
Does this PR introduce a user-facing change?